Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump SDK master version #212

Merged
merged 7 commits into from
Dec 12, 2019
Merged

Bump SDK master version #212

merged 7 commits into from
Dec 12, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Dec 5, 2019 •
edited
Loading

Use new --keyring-backend flag.

See cosmos/cosmos-sdk#5355 for more information.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio mentioned this pull request Dec 5, 2019
Merged
5 tasks
@alessio alessio added R4R scope: CLI Issues and features pertaining to Gaia's CLI client. labels Dec 5, 2019
golangcibot
golangcibot reviewed Dec 6, 2019
View reviewed changes
cli_test/test_helpers.go Outdated Show resolved Hide resolved
cmd/gaiad/genaccounts.go Outdated Show resolved Hide resolved
lcd_test/lcd_test.go Outdated Show resolved Hide resolved
golangcibot
golangcibot reviewed Dec 7, 2019
View reviewed changes
cmd/gaiad/testnet.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK. I tested only os and test, not file. I also left a minor question in the integration tests.

EDIT: Let's also update the gaiacli/client docs on the three options and their details.

alexanderbez
alexanderbez approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez
Copy link
Contributor

Mind fixing CI issues @alessio? You can merge after 👍

fedekunze
fedekunze approved these changes Dec 11, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Pending CI fixes

go.mod Show resolved Hide resolved
@alessio
Copy link
Contributor Author

alessio commented Dec 11, 2019 via email

Alessio Treglia and others added 2 commits December 11, 2019 16:49
@alexanderbez alexanderbez changed the title Update against cosmos-sdk respective branch Bump SDK master version Dec 11, 2019
@codecov
Copy link

codecov bot commented Dec 11, 2019 •
edited
Loading

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   65.24%   65.24%           
=======================================
  Files           5        5           
  Lines         515      515           
=======================================
  Hits          336      336           
  Misses        148      148           
  Partials       31       31
Impacted Files Coverage Δ
lcd_test/helpers.go 75.53% <80%> (ø) ⬆️

@alessio alessio merged commit 47eca7b into master Dec 12, 2019
@alessio alessio deleted the alessio/keyring-file-backend branch December 12, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
scope: CLI Issues and features pertaining to Gaia's CLI client.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @alexanderbez @fedekunze @golangcibot