global fee refactor #2316
Merged
global fee refactor #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve code readability
yaruwangway
reviewed
Mar 21, 2023
| }, | ||
| uint64(1000), | ||
| expCoins, | ||
| }, |
There was a problem hiding this comment.
can add test case for:
- zero coins min gas price, get empty coins
- zero coins, non-zero coins mix min gas price, get only the non-zero coins
yaruwangway
reviewed
Mar 21, 2023
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
+ Coverage 83.40% 84.32% +0.91%
==========================================
Files 22 22
Lines 1555 1544 -11
==========================================
+ Hits 1297 1302 +5
+ Misses 207 194 -13
+ Partials 51 48 -3
|
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
yaruwangway
reviewed
Mar 22, 2023
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
sainoe
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
MSalopek and
shaspitz
as code owners
Co-authored-by: Marius Poke <marius.poke@posteo.de>
yaruwangway
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2321