Fix typos and Consumer vs Child chain naming #2317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-offtermatt
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
sainoe,
MSalopek and
shaspitz
as code owners
mpoke
approved these changes
Mar 22, 2023
|
@mmulji-ic @jtremback is this document still needed? |
Think this was added as there was no other ICS documentation, now there is, so this could be removed. Check any references to this doc and point to the new ICS site. |
mmulji-ic
approved these changes
Apr 2, 2023
I opened this issue #2348 to deal with this. In the meantime, there is no reason to update the doc. As a result, I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, Consumer Chains were called child chains. I changed it to Consumer Chains.
Also, I fixed a few minor typos.