Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in tests breaking the linter #2403

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix bug in tests breaking the linter #2403

merged 1 commit into from
Apr 14, 2023

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Apr 14, 2023

PR #2351 contained a misnamed method call in a test that was causing the linter and UTs to fail.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #2403 (8687ab5) into main (53397fa) will decrease coverage by 0.20%.
The diff coverage is 93.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   84.32%   84.12%   -0.20%     
==========================================
  Files          22       22              
  Lines        1544     1531      -13     
==========================================
- Hits         1302     1288      -14     
- Misses        194      195       +1     
  Partials       48       48              
Impacted Files Coverage Δ
x/globalfee/ante/fee.go 84.92% <90.69%> (-2.18%) ⬇️
x/globalfee/ante/fee_utils.go 100.00% <100.00%> (+2.38%) ⬆️

@sainoe sainoe changed the title Fix bug in tests breaking the linter Fix bug in UTs breaking the linter Apr 14, 2023
@sainoe sainoe changed the title Fix bug in UTs breaking the linter Fix bug in tests breaking the linter Apr 14, 2023
@sainoe sainoe marked this pull request as ready for review April 14, 2023 13:01
@sainoe sainoe merged commit 871ee35 into main Apr 14, 2023
@sainoe sainoe deleted the sainoe/2327-fix branch April 14, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants