-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run golang tests #2443
ci: run golang tests #2443
Conversation
@faddat if you want to start work on an issue, please request beforehand and have a convo to understand whats intended. |
@mmulji-ic -- I assume that you'd had something more complex in mind -- this just tests multiple platforms with go test ./... Can also implement matrix testing |
No problems, I started working on this already, but lets have a chat tomorrow. I can tell you what I intended and we can continue on this PR. |
cool :). I think it's not the same thing as what this PR does. Basically just saw the issue and figured I would add moire multiplatformness |
@faddat Thank you for contributing to Gaia. To ensure a smooth workflow for all contributors, please read the contributing guidelines for this repo https://github.com/cosmos/gaia/blob/main/CONTRIBUTING.md. We have asked this repeatedly. It is highly unprofessional to start working on an issue already assigned to somebody else. In the future, please follow the guidelines, otherwise your contributions will be rejected without review. |
@faddat take a look at workflow that I was working on. I think we want to change the nightly checks to run the multi-platform tests. Also we want to reuse the
Note that |
Good day @mpoke -- I did not in fact think that this would complete the issue. Good day @mmulji-ic I wanna let you know that I did not intend to stop you from doing your work. I actually figured that this would sit aside it, and enhance rigor overall. If that is not the case, please just let me know and I'm happy to close the pr. You mention repeatedly @mpoke - in what other case have I stepped over the boundary? Thank you |
closing due to protest from stewarding team |
Description
This will run tests on multiple platforms.
Touches on but does not close: #2441
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change