Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run golang tests #2443

Closed
wants to merge 2 commits into from
Closed

ci: run golang tests #2443

wants to merge 2 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 25, 2023

Description

This will run tests on multiple platforms.

Touches on but does not close: #2441

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mmulji-ic
Copy link
Contributor

@faddat if you want to start work on an issue, please request beforehand and have a convo to understand whats intended.

@faddat
Copy link
Contributor Author

faddat commented Apr 25, 2023

@mmulji-ic -- I assume that you'd had something more complex in mind -- this just tests multiple platforms with go test ./...

Can also implement matrix testing

@mmulji-ic
Copy link
Contributor

@mmulji-ic -- I assume that you'd had something more complex in mind -- this just tests multiple platforms with go test ./...

Can also implement matrix testing

No problems, I started working on this already, but lets have a chat tomorrow. I can tell you what I intended and we can continue on this PR.

@faddat
Copy link
Contributor Author

faddat commented Apr 25, 2023

cool :).

I think it's not the same thing as what this PR does. Basically just saw the issue and figured I would add moire multiplatformness

@mpoke
Copy link
Contributor

mpoke commented Apr 26, 2023

@faddat Thank you for contributing to Gaia. To ensure a smooth workflow for all contributors, please read the contributing guidelines for this repo https://github.com/cosmos/gaia/blob/main/CONTRIBUTING.md. We have asked this repeatedly.

It is highly unprofessional to start working on an issue already assigned to somebody else.

Screenshot 2023-04-26 at 09 54 12

In the future, please follow the guidelines, otherwise your contributions will be rejected without review.

@mmulji-ic
Copy link
Contributor

mmulji-ic commented Apr 26, 2023

@faddat take a look at workflow that I was working on.

I think we want to change the nightly checks to run the multi-platform tests.

Also we want to reuse the test.yml and sims.yml in the nightlies. The GH action syntax below, needs to be fixed, is that something you can continue with?

name: "Nightly E2E run"
on:
  workflow_call:
  workflow_dispatch:
  schedule:
    - cron: "0 0 * * *"
  push:
    branches: [ main, rc/v*, release/v* ]

jobs:
  matrix-tests:
    strategy:
      fail-fast: false
      max-parallel: 3
      matrix:
        os: [ubuntu-latest, macos-latest, windows-latest]       # We can add custom runners - https://github.com/actions/runner
    runs-on: ${{ matrix.os }}
    steps:
      - name: run-tests
        uses: cosmos/gaia/.github/workflows/test.yml@main
      - name: run-simulations
        uses: cosmos/gaia/.github/workflows/sims.yml@main

Note that main is already on go 1.20.x, so we should skip running tests for go 1.19.x.

@mmulji-ic mmulji-ic requested a review from dasanchez April 26, 2023 11:28
@faddat
Copy link
Contributor Author

faddat commented Apr 28, 2023

Good day @mpoke

-- I did not in fact think that this would complete the issue.

Good day @mmulji-ic I wanna let you know that I did not intend to stop you from doing your work. I actually figured that this would sit aside it, and enhance rigor overall.

If that is not the case, please just let me know and I'm happy to close the pr.

You mention repeatedly @mpoke - in what other case have I stepped over the boundary? Thank you

@faddat
Copy link
Contributor Author

faddat commented Apr 29, 2023

closing due to protest from stewarding team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement CI testing against main/release branches for the selected platforms.
3 participants