Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce the use of go 1.20, making mixed runtimes impossible #2472

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 7, 2023

THis PR makes it impossible to use any version of Go below 1.20 with Gaia.

Go has a builtin install command like:

go install ./...

many validators use it. It fully bypasses the go version check in Makefile.

@mpoke mpoke deleted the branch cosmos:v9.0.x-with-denom-and-multisig-fix May 8, 2023 11:28
@mpoke mpoke closed this May 8, 2023
@mpoke
Copy link
Contributor

mpoke commented May 8, 2023

@faddat Thanks for your contribution. This PR was closed automatically when #2474 was merged. Since this emergency release was not tested with go 1.20, we decided to not risk it and add it to the upgrade. The next planed Gaia upgrade will bump go to 1.20; main already uses go 1.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants