Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump ics to v1.1.0-multiden #2522

Closed
wants to merge 1 commit into from
Closed

deps: bump ics to v1.1.0-multiden #2522

wants to merge 1 commit into from

Conversation

yaruwangway
Copy link
Contributor

@yaruwangway yaruwangway commented May 23, 2023

Description

Closes: NA


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@sainoe
Copy link
Contributor

sainoe commented May 24, 2023

Are we sure this PR addresses the correct issue?

@mpoke mpoke changed the title bump ics to v1.1.0-multiden deps: bump ics to v1.1.0-multiden May 30, 2023
@mpoke mpoke mentioned this pull request May 30, 2023
8 tasks
@mpoke
Copy link
Contributor

mpoke commented May 30, 2023

Closed in favor of #2559.

@mpoke mpoke closed this May 30, 2023
@yaruwangway yaruwangway deleted the yaru/bump-ics branch June 21, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants