docs: updating release procedure #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
p-offtermatt
approved these changes
Sep 25, 2023
bermuell
reviewed
Sep 25, 2023
Co-authored-by: bernd-m <43466467+bermuell@users.noreply.github.com>
MSalopek
reviewed
Sep 27, 2023
| @@ -62,20 +60,58 @@ An exception are PRs open via the Github mergify integration (i.e., backported P | |||
| * When bugs are found, create a PR for `main`, and backport fixes to the release branch. | |||
| * Create new release candidate tags after bugs are fixed. | |||
| * After the team feels the release candidate is mainnet ready, create a full release: | |||
| * Update `CHANGELOG.md`. | |||
| * Run `make format` to format the code. | |||
| * **Note:** The final release MUST have the same commit hash as the latest corresponding release candidate. | |||
There was a problem hiding this comment.
Suggested change
| * **Note:** The final release MUST have the same commit hash as the latest corresponding release candidate. | |
| * **Note:** The final release SHOULD have the same commit hash as the latest corresponding release candidate. |
Just in case something goes wrong with CI?
MSalopek
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: NA
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:prefix in the PR title