test: add E2E on changing the BlocksPerEpoch parameter #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insumity
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
insumity
commented
Apr 9, 2024
| @@ -81,6 +81,8 @@ func (s *IntegrationTestSuite) TestGov() { | |||
| s.GovCancelSoftwareUpgrade() | |||
| s.GovCommunityPoolSpend() | |||
| s.AddRemoveConsumerChain() | |||
|
|
|||
| s.testSetBlocksPerEpoch() | |||
There was a problem hiding this comment.
This new test practically tests that governance proposals work for BlocksPerEpoch and hence why testSetBlocksPerEpoch() appears under TestGov.
insumity
force-pushed
the
insumity/e2e-blocks-per-epoch
branch
from
1b77aec to
40a63a2
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an E2E on changing the
BlocksPerEpochparameter through a governance proposal.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change