Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add upgrade handler for initializing ICS epochs #3079

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Apr 22, 2024

Description

Closes: #XXXX

Add the initial consumer validator sets for all consumer chains. This is needed by ICS epochs.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke changed the title fix!: add upgrade handler for initializing ICS epochs feat!: add upgrade handler for initializing ICS epochs Apr 22, 2024
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks.

@sainoe
Copy link
Contributor

sainoe commented Apr 23, 2024

LGTM! Well done.

@sainoe sainoe self-requested a review April 23, 2024 06:33
@MSalopek MSalopek merged commit 5c5447c into main Apr 23, 2024
17 checks passed
@MSalopek MSalopek deleted the marius/init-ics-epochs branch April 23, 2024 06:48
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
* add upgrade handler for initializing ICS epochs

* adding changelog entries

* fix test

(cherry picked from commit 5c5447c)

# Conflicts:
#	.changelog/v16.0.0/dependencies/3079-init-ics-epochs.md
#	.changelog/v16.0.0/features/3079-init-ics-epochs.md
mpoke added a commit that referenced this pull request Apr 23, 2024
… (#3080)

* feat!: add upgrade handler for initializing ICS epochs (#3079)

* add upgrade handler for initializing ICS epochs

* adding changelog entries

* fix test

(cherry picked from commit 5c5447c)

# Conflicts:
#	.changelog/v16.0.0/dependencies/3079-init-ics-epochs.md
#	.changelog/v16.0.0/features/3079-init-ics-epochs.md

* fixing changelog

---------

Co-authored-by: Marius Poke <marius.poke@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants