Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build with cosmos-sdk v0.41.4 #712

Merged
merged 2 commits into from
Mar 2, 2021
Merged

build with cosmos-sdk v0.41.4 #712

merged 2 commits into from
Mar 2, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 2, 2021


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #712 (6bf1948) into main (dbabd61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   12.33%   12.33%           
=======================================
  Files           8        8           
  Lines         697      697           
=======================================
  Hits           86       86           
  Misses        593      593           
  Partials       18       18           

@jgimeno
Copy link
Contributor

jgimeno commented Mar 2, 2021

Migration key (except ledger) tested and working fine.

@tac0turtle
Copy link
Member

tested on mainnet. Opened another PR to clean up logs, we should wait for that.

@alessio alessio marked this pull request as ready for review March 2, 2021 18:53
@alessio
Copy link
Contributor Author

alessio commented Mar 2, 2021

Cosmos SDK v0.41.4 is out. And this should be ready to go 🙏

@shahankhatch shahankhatch merged commit 511004b into main Mar 2, 2021
@shahankhatch shahankhatch deleted the gaia+sdk0.41.4 branch March 2, 2021 20:37
shahankhatch pushed a commit that referenced this pull request Mar 2, 2021
* build with cosmos-sdk v0.41.4

* update to sdk v0.41.4 final
shahankhatch pushed a commit that referenced this pull request Mar 2, 2021
* build with cosmos-sdk v0.41.4

* update to sdk v0.41.4 final
faddat added a commit to faddat/gaia that referenced this pull request Mar 4, 2021
* https://github.com/cosmos/gaia:
  Changelog for v4.0.5 (cosmos#714)
  [Security] Bump pug-code-gen from 2.0.2 to 2.0.3 in /docs (cosmos#716)
  build with cosmos-sdk v0.41.4 (cosmos#712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants