Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare gaia alpha release for cosmoshub-4.6 upgrade #834

Closed
wants to merge 26 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c1a41c2
Update gaiad deps to Cosmos SDK v0.43-alpha1 and ibc-go v1.0.0-alpha1
shahankhatch Apr 27, 2021
5b3c805
Updates Service Provider Guide (#826)
Apr 27, 2021
b39e555
Changes version in reproducible-builds (#835)
Apr 27, 2021
f51d367
Change identifier of long-running sim based on label (#839)
shahankhatch Apr 28, 2021
85e2676
Remove file filter for running long-running sim based on label (#840)
shahankhatch Apr 28, 2021
4b9958d
Remove diff check from github action for long-running sim (#841)
shahankhatch Apr 29, 2021
c77cd15
Add compilation prerequisites (#837)
shahankhatch Apr 29, 2021
09f9d8d
Update gaia build to go1.16 (#838)
shahankhatch Apr 29, 2021
7117a91
Delete Dockerfile (#844)
faddat May 3, 2021
fa96bee
Removing unused docker action until requirements are defined (#850)
shahankhatch May 7, 2021
ab74ade
Adding submission and PR guidelines (#849)
shahankhatch May 7, 2021
830c0ca
Merge pull request #853
Puzanira May 11, 2021
986a9a3
Fix for the --home flag (#852)
zmanian May 11, 2021
69ab1d2
cosmoshub-4.6 module integrations (#854)
shahankhatch May 11, 2021
9c3829d
Increment gaia version to v5 (#855)
shahankhatch May 11, 2021
eb5bb34
Update gaiad deps to Cosmos SDK v0.43-alpha1 and ibc-go v1.0.0-alpha1
shahankhatch Apr 27, 2021
4e97411
Fix for the --home flag (#852)
zmanian May 11, 2021
fc6dc88
cosmoshub-4.6 module integrations (#854)
shahankhatch May 11, 2021
b8475a6
Increment gaia version to v5 (#855)
shahankhatch May 11, 2021
76a1836
Update go.sum
shahankhatch May 11, 2021
c6dff47
Merge remote-tracking branch 'origin/hub/cosmoshub-4.6' into hub/cosm…
shahankhatch May 11, 2021
6a2ce91
Register feegrant module with sim
shahankhatch May 12, 2021
1723fc7
Bumped to sdk beta1 and ibc alpha2
shahankhatch May 12, 2021
99c77cd
Register authz module with sim module
shahankhatch May 12, 2021
f04a23f
Register authz module, for real
shahankhatch May 12, 2021
0101175
Updated ibc integration based on ibc migration guide
shahankhatch May 17, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 0 additions & 64 deletions .github/workflows/docker.yml

This file was deleted.

12 changes: 2 additions & 10 deletions .github/workflows/sim-label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
path: ~/go/bin
key: ${{ runner.os }}-go-runsim-binary

test-sim-nondeterminism:
test-sim-nondeterminism-labeled:
if: ${{ github.event.label.name == 'sim' }}
runs-on: ubuntu-latest
needs: newbuild
Expand All @@ -34,18 +34,10 @@ jobs:
- uses: actions/setup-go@v2.1.3
with:
go-version: 1.16
- uses: technote-space/get-diff-action@v4
with:
PATTERNS: |
**/**.go
go.mod
go.sum
- uses: actions/cache@v1
with:
path: ~/go/bin
key: ${{ runner.os }}-go-runsim-binary
if: "env.GIT_DIFF != ''"
- name: test nondeterminism
run: |
make test-sim-nondeterminism
if: "env.GIT_DIFF != ''"
make test-sim-nondeterminism
12 changes: 6 additions & 6 deletions .github/workflows/sims.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/setup-go@v2.1.3
with:
go-version: 1.15
go-version: 1.16
- name: Install runsim
run: export GO111MODULE="on" && go get github.com/cosmos/tools/cmd/runsim@v1.0.0
- uses: actions/cache@v1
Expand All @@ -33,7 +33,7 @@ jobs:
# - uses: actions/checkout@v2
# - uses: actions/setup-go@v2.1.3
# with:
# go-version: 1.15
# go-version: 1.16
# - uses: technote-space/get-diff-action@v4
# with:
# PATTERNS: |
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2.1.3
with:
go-version: 1.15
go-version: 1.16
- uses: actions/cache@v1
with:
path: ~/go/bin
Expand All @@ -80,7 +80,7 @@ jobs:
steps:
- uses: actions/setup-go@v2.1.3
with:
go-version: 1.15
go-version: 1.16
- uses: actions/checkout@v2
- uses: technote-space/get-diff-action@v4
with:
Expand All @@ -105,7 +105,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2.1.3
with:
go-version: 1.15
go-version: 1.16
- uses: technote-space/get-diff-action@v4
with:
PATTERNS: |
Expand All @@ -130,7 +130,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2.1.3
with:
go-version: 1.15
go-version: 1.16
- uses: technote-space/get-diff-action@v4
with:
PATTERNS: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/setup-go@v2.1.3
with:
go-version: 1.15
go-version: 1.16
- uses: actions/checkout@v2
- uses: technote-space/get-diff-action@v4
with:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
## [Unreleased]

* (tendermint) Bump Tendermint version to [v0.34.10](https://github.com/tendermint/tendermint/releases/tag/v0.34.10).
* (golang) Bump golang prerequisite from 1.15 to 1.16.

## [v4.2.1] - 2021-04-08

Expand Down
27 changes: 25 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,38 @@ Other notes:
A convenience git `pre-commit` hook that runs the formatters automatically
before each commit is available in the `contrib/githooks/` directory.

## Pull Requests
## Submissions

Generally, when structuring a submission for the Cosmos ecosystem, the submission might span multiple layers
of the technology stack, including the Cosmos SDK and Tendermint dependencies.

### Structuring a submission

To accommodate review process we suggest that PRs are categorically broken up.
Ideally each PR addresses only a single issue. Additionally, as much as possible
code refactoring and cleanup should be submitted as a separate PRs from bugfixes/feature-additions.

In order to simplify reviewing large changes, submissions should have a created an issue
with a description of the submission, a description tracking the changes and relevant discussions,
and a checklist of changes and tasks to be done.

The issue can then be used to develop multiple well-scoped PRs that are easy to review.

The following PR structuring checklist can be used when submitting changes to the Gaia repository for review:
- [ ] Proto files: PR updating proto files. As a suggested next step, don't regenerate updated protobuf
implementations using `protgen`, since this will break existing code.
- [ ] Broken code: If `protogen` is run, a PR disabling broken code
- [ ] Validation: PR with validation of types
- [ ] Functionality: PR integrating supporting functionality
- [ ] Servers: PR for `msgserver` and `queryserver`
- [ ] CLI: PR for CLI commands
- [ ] Orchestrators: PR for any orchestrators
- [ ] Genesis: PR for genesis
- [ ] Upgrades: PR for upgrades

### Process for reviewing PRs

All PRs require two Reviews before merge (except docs changes, or variable name-changes which only require one). When reviewing PRs please use the following review explanations:
All PRs require at least one review before merge (except docs changes, or variable name-changes which only require one). When reviewing PRs please use the following review explanations:

- `LGTM` without an explicit approval means that the changes look good, but you haven't pulled down the code, run tests locally and thoroughly reviewed it.
- `Approval` through the GH UI means that you understand the code, documentation/spec is updated in the right places, you have pulled down and tested the code locally. In addition:
Expand Down
41 changes: 0 additions & 41 deletions Dockerfile

This file was deleted.

Loading