perf: skip debug work when not in debug mode #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MergedFileDescriptors was unconditionally checking import paths and file
descriptor differences, then conditionally returning the differences as
an error. There is no need to check the differences if we will never
return them.
This made a measurable difference in running simd q:
$ hyperfine --warmup 4 -r 50 '/tmp/simd-dodebugwork q' '/tmp/simd-skipdebugwork q'
Benchmark 1: /tmp/simd-dodebugwork q
Time (mean ± σ): 121.6 ms ± 6.5 ms [User: 173.6 ms, System: 23.7 ms]
Range (min … max): 117.0 ms … 162.7 ms 50 runs
Warning: Statistical outliers were detected. ...
Benchmark 2: /tmp/simd-skipdebugwork q
Time (mean ± σ): 113.6 ms ± 6.5 ms [User: 158.5 ms, System: 23.1 ms]
Range (min … max): 109.3 ms … 139.7 ms 50 runs
Warning: Statistical outliers were detected. ...
Summary
'/tmp/simd-skipdebugwork q' ran
1.07 ± 0.08 times faster than '/tmp/simd-dodebugwork q'
And on two single runs of TestAppStateDeterminism, this optimization
reduced local runtime from 20.9 seconds to 19.7, an anecdotal ~6%
speedup.
facundomedica
approved these changes
Apr 13, 2023
tac0turtle
approved these changes
Apr 13, 2023
The outdated versions seem to be causing CI failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MergedFileDescriptorswas unconditionally checking import paths and file descriptor differences, then conditionally returning the differences as an error. There is no need to check the differences if we will never return them.This made a measurable difference in running simd q:
And on two single runs of
TestAppStateDeterminism, this optimization reduced local runtime from 20.9 seconds to 19.7, an anecdotal ~6% speedup.