refactor!: upgrade golang.org/x/exp to latest #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasincs
changed the title
|
Given that people when depending on cosmos/gogoproto and trying to bump to latest pseudo version of |
julienrbrt
approved these changes
Aug 9, 2023
julienrbrt
changed the title
beer-1
added a commit
to initia-labs/cosmos-sdk
that referenced
this pull request
Dec 8, 2023
beer-1
added a commit
to initia-labs/cosmos-sdk
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently golang.org/x/exp package decided to change function signature for SortFunc to align better with cmp package
reasoning is here:
golang/go#60091 (comment)
this is likely going to be standard for Go 1.21 and going forward