all: fix tests by migrating to github.com/onsi/ginkgo/v2 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a stale dependency by migrating to the recommended v2 version, and that was purposefully failing tests such as in https://github.com/cosmos/gosec/actions/runs/3116664571/jobs/5054700976#step:5:647 While here, also fixed a flake with comparisons of sorts that weren't in order.
odeke-em
force-pushed
the
fix-test-with-ginkgo-migration-to-v2
branch
from
e869e27 to
aa9df55
Compare
Codecov ReportBase: 70.86% // Head: 71.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 70.86% 71.77% +0.90%
==========================================
Files 9 9
Lines 587 627 +40
==========================================
+ Hits 416 450 +34
- Misses 146 149 +3
- Partials 25 28 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a stale dependency by migrating to the recommended v2 version, and that was purposefully failing tests such as in https://github.com/cosmos/gosec/actions/runs/3116664571/jobs/5054700976#step:5:647
While here, also fixed a flake with comparisons of sorts that weren't in order.