rules/sdk: intelligently flag overflowing uint*->uint* + int*->int* conversions #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a kind FYI to @elias-orijtech @kirbyquerby @willpoint @ebuchman @tac0turtle @jhusdero and this change will cut down massively on false positives |
…onversions
Retrieve the underlying types to perform smarter conversions.
More importantly, this change intelligently flags overflowing
conversions for homogenous signedness aka:
* int* -> int*
* uint* -> uint*
whereby for each same signedness, just check widths where:
+ 64-bit machines:
uint64 == uint > uint32 > uint16 > uint8
int64 == int > int32 > int16 > int8
+ 32-bit machines:
uint64 > uint == uint32 > uint16 > uint8
int64 > int == int32 > int16 > int8
and this change only flags the offending non-fitting conversions.
For an exhibit, this code
```go
package inttests
type in = int
type uin = uint
func it() {
_ = uint64(uint32(0))
_ = uint(uint32(0))
_ = uint(uint16(0))
_ = uint(uint8(0))
_ = uint(uint64(0))
_ = uint32(uint64(0))
_ = uint16(uint64(0))
_ = uint8(uint64(0))
_ = uint8(uint(0))
_ = uint8(uint32(0))
_ = uint8(uint64(0))
_ = int(uint(0))
_ = in(uint(0))
_ = uin(uint(0))
_ = uin(uint32(0))
}
```
* Previously:
+ Could not catch the aliased int with overflowing potential from uint
+ Falsely flagged all the rest as overflowing so 12 issues
* Currently:
+ Catches the aliased int with overflowing potential from uint
+ Only flags the actually overflowing conversions so only 8 issues
Fixes #56
Fixes #57
odeke-em
force-pushed
the
rules-sdk-consider-uint+-int+-conversions
branch
from
e5034d7 to
9592313
Compare
|
Confirmed that this change reduces the reports in cosmos-sdk from 1,045 down to 837, it eliminated a bunch of false positives! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the underlying types to perform smarter conversions. More importantly, this change intelligently flags overflowing conversions for homogenous signedness aka:
whereby for each same signedness, just check widths where:
64-bit machines: uint64 == uint > uint32 > uint16 > uint8
int64 == int > int32 > int16 > int8
32-bit machines: uint64 > uint == uint32 > uint16 > uint8
int64 > int == int32 > int16 > int8
and this change only flags the offending non-fitting conversions. For an exhibit, this code
Fixes #56
Fixes #57