Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules/sdk: allow packages with */crypto/* to import unsafe #64

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

odeke-em
Copy link
Collaborator

Cryptographic packages require crypto/rand and other seemingly unsafe packages. This change removes those false positives by checking that segments of the package's path contain "crypto" and if so allow these "unsafe" packages.

Fixes #63

Cryptographic packages require crypto/rand and other seemingly
unsafe packages. This change removes those false positives by
checking that segments of the package's path contain "crypto" and if
so allow these "unsafe" packages.

Fixes #63
@odeke-em odeke-em merged commit 05a47ad into master Oct 22, 2022
@odeke-em odeke-em deleted the allow-crypto-modules-to-import-unsafe branch October 22, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rules/sdk: G702: Blocklisted import crypto/rand should not flag for crypto related code
1 participant