check version<0 in deleteVersion #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Dec 14, 2020
| @@ -516,7 +516,7 @@ func (tree *MutableTree) SaveVersion() ([]byte, int64, error) { | |||
| } | |||
|
|
|||
| func (tree *MutableTree) deleteVersion(version int64) error { | |||
| if version == 0 { | |||
| if version <= 0 { | |||
There was a problem hiding this comment.
Is there a tradeoff between this and migrating to uin64? Out of scope for this PR but curious.
There was a problem hiding this comment.
uint64 is a breaking change, since we use int64 in the public APIs. I believe this is also persisted to disk. Otherwise, yeah, it should really be uint64.
tac0turtle
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345. This would cause an error in any case, since the version does not exist, but it's better to catch it here.