Move job into e2e-upgrade.

cosmos · Nov 2, 2023 · 00c9681 · 00c9681
1 parent 963eb9d
commit 00c9681
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 19 deletions.
diff --git a/.github/workflows/e2e-test-workflow-call.yml b/.github/workflows/e2e-test-workflow-call.yml
@@ -72,11 +72,6 @@ on:
         required: false
         type: boolean
         default: false
-      slack-notify:
-        description: 'Specify flag to indicate that slack should be notified on failure'
-        required: false
-        type: boolean
-        default: false
 
 env:
   REGISTRY: ghcr.io
@@ -198,9 +193,3 @@ jobs:
           name: '${{ matrix.entrypoint }}-${{ matrix.test }}'
           path: e2e/diagnostics
           retention-days: 5
-
-  slack-notify:
-    needs: e2e-tests
-    uses: ./.github/workflows/slack-notify.yaml
-    secrets: inherit
-    if: ${{ always() && needs.e2e-tests.result == 'failure' && inputs.slack-notify }}
diff --git a/.github/workflows/e2e-upgrade.yaml b/.github/workflows/e2e-upgrade.yaml
@@ -25,7 +25,6 @@ jobs:
       test: "TestIBCChainUpgrade"
       upload-logs: true
       relayer-type: hermes
-      slack-notify: true
 
   upgrade-v7-hermes:
     uses: ./.github/workflows/e2e-test-workflow-call.yml
@@ -40,7 +39,6 @@ jobs:
       test: "TestV6ToV7ChainUpgrade"
       upload-logs: true
       relayer-type: hermes
-      slack-notify: true
 
   upgrade-v7_1-hermes:
     uses: ./.github/workflows/e2e-test-workflow-call.yml
@@ -55,7 +53,6 @@ jobs:
       test: "TestV7ToV7_1ChainUpgrade"
       upload-logs: true
       relayer-type: hermes
-      slack-notify: true
 
   upgrade-v8-hermes:
     uses: ./.github/workflows/e2e-test-workflow-call.yml
@@ -70,7 +67,6 @@ jobs:
       test: "TestV7ToV8ChainUpgrade"
       upload-logs: true
       relayer-type: hermes
-      slack-notify: true
 
   upgrade-v5-rly:
     uses: ./.github/workflows/e2e-test-workflow-call.yml
@@ -87,7 +83,6 @@ jobs:
       relayer-type: rly
       relayer-image: ghcr.io/cosmos/relayer
       relayer-tag: latest
-      slack-notify: true
 
   upgrade-v7-rly:
     uses: ./.github/workflows/e2e-test-workflow-call.yml
@@ -104,7 +99,6 @@ jobs:
       relayer-type: rly
       relayer-image: ghcr.io/cosmos/relayer
       relayer-tag: latest
-      slack-notify: true
 
   upgrade-v7_1-rly:
     uses: ./.github/workflows/e2e-test-workflow-call.yml
@@ -121,7 +115,6 @@ jobs:
       relayer-type: rly
       relayer-image: ghcr.io/cosmos/relayer
       relayer-tag: latest
-      slack-notify: true
 
   upgrade-v8-rly:
     uses: ./.github/workflows/e2e-test-workflow-call.yml
@@ -138,4 +131,9 @@ jobs:
       relayer-type: rly
       relayer-image: ghcr.io/cosmos/relayer
       relayer-tag: latest
-      slack-notify: true
+
+  slack-notify:
+    needs: [upgrade-v5-hermes, upgrade-v7-hermes, upgrade-v7_1-hermes, upgrade-v8-hermes, upgrade-v5-rly, upgrade-v7-rly, upgrade-v7_1-rly, upgrade-v8-rly]
+    uses: ./.github/workflows/slack-notify.yaml
+    secrets: inherit
+    if: ${{ always() && contains(needs.*.result, 'failure') }}