imp(transfer_test): improved tests without type assertion

cosmos · Aug 1, 2023 · 11a859a · 11a859a
1 parent aa3fe0f
commit 11a859a
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/modules/apps/transfer/types/packet_test.go b/modules/apps/transfer/types/packet_test.go
@@ -49,7 +49,7 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
 	testCases := []struct {
 		name              string
 		packetData        types.FungibleTokenPacketData
-		expAdditionalData map[string]interface{}
+		expAdditionalData interface{}
 	}{
 		{
 			"success: src_callback key in memo",
@@ -79,43 +79,42 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
 			},
 		},
 		{
-			"failure: empty memo",
+			"success: src_callback has string value",
 			types.FungibleTokenPacketData{
 				Denom:    denom,
 				Amount:   amount,
 				Sender:   sender,
 				Receiver: receiver,
-				Memo:     "",
+				Memo:     `{"src_callback": "string"}`,
 			},
-			nil,
+			"string",
 		},
 		{
-			"failure: non-json memo",
+			"failure: empty memo",
 			types.FungibleTokenPacketData{
 				Denom:    denom,
 				Amount:   amount,
 				Sender:   sender,
 				Receiver: receiver,
-				Memo:     "invalid",
+				Memo:     "",
 			},
 			nil,
 		},
 		{
-			"failure: invalid src_callback key",
+			"failure: non-json memo",
 			types.FungibleTokenPacketData{
 				Denom:    denom,
 				Amount:   amount,
 				Sender:   sender,
 				Receiver: receiver,
-				Memo:     `{"src_callback": "invalid"}`,
+				Memo:     "invalid",
 			},
 			nil,
 		},
 	}
 
 	for _, tc := range testCases {
-		additionalData, ok := tc.packetData.GetCustomPacketData("src_callback").(map[string]interface{})
-		suite.Require().Equal(ok, additionalData != nil)
-		suite.Require().Equal(tc.expAdditionalData, additionalData)
+		customData := tc.packetData.GetCustomPacketData("src_callback")
+		suite.Require().Equal(tc.expAdditionalData, customData)
 	}
 }