chore: apply review suggestion #1976 (comment)

cosmos · Mar 22, 2023 · f03761b · f03761b
1 parent 7f39d75
commit f03761b
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/docs/architecture/adr-008-app-caller-cbs/adr-008-app-caller-cbs.md b/docs/architecture/adr-008-app-caller-cbs/adr-008-app-caller-cbs.md
@@ -1,11 +1,13 @@
 # ADR 008: Callback to IBC Actors
 
 ## Changelog
+
 * 2022-08-10: Initial Draft
+* 2023-03-22: Merged
 
 ## Status
 
-Proposed
+Accepted, packet callback interface implemented
 
 ## Context
 
@@ -51,23 +53,23 @@ type IBCActor interface {
 type PacketActor interface {
  // OnRecvPacket will be called on the IBCActor after the IBC Application
  // handles the RecvPacket callback if the packet has an IBC Actor as a receiver.
- OnRecvPacket(ctx sdk.Context, packet channeltypes.Packet, relayer string) error
+ OnRecvPacket(ctx sdk.Context, packet channeltypes.Packet, relayer sdk.AccAddress) error
 
  // OnAcknowledgementPacket will be called on the IBC Actor
  // after the IBC Application handles its own OnAcknowledgementPacket callback
  OnAcknowledgmentPacket(
  ctx sdk.Context,
  packet channeltypes.Packet,
  ack exported.Acknowledgement,
- relayer string
+ relayer sdk.AccAddress,
  ) error
 
  // OnTimeoutPacket will be called on the IBC Actor
  // after the IBC Application handles its own OnTimeoutPacket callback
  OnTimeoutPacket(
  ctx sdk.Context,
  packet channeltypes.Packet,
- relayer string
+ relayer sdk.AccAddress,
  ) error
 }
 ```
@@ -245,7 +247,7 @@ func (im IBCModule) OnAcknowledgementPacket(
  ctx sdk.Context,
  packet channeltypes.Packet,
  acknowledgement []byte,
- relayer string,
+ relayer sdk.AccAddress,
 ) error {
  // application-specific onAcknowledgmentPacket logic
 
@@ -298,7 +300,7 @@ func (im IBCModule) OnAcknowledgementPacket(
 func (im IBCModule) OnTimeoutPacket(
  ctx sdk.Context,
  packet channeltypes.Packet,
- relayer string,
+ relayer sdk.AccAddress,
 ) error {
  // application-specific onTimeoutPacket logic