-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration docs for 02-client refactor #1202
Comments
can I try doing this ? |
Sure, @catShaark. Thanks for volunteering! Would it be possible for you to open a PR for this issue before the end of next week? As you can see in our project board this issue is part of our current iteration (ending April 29th) and the goal would be to complete these issues in the board to create an alpha tag. @colin-axner would you like to add any more details in the issue of what you would like to see in the docs so that @catShaark can take that into account? |
Excellent @catShaark, that'd be wonderful. Here's what I had in mind: There's a few major changes involved here:
some minor changes:
Let me know if you have any questions. If you only feel comfortable adding entries for a few of these changes, that's totally fine, we will pick up the rest. Any contribution is greatly appreciated :) |
@colin-axner thanks for the summary, I will dig into this and ask you if I get stuck. |
@colin-axner should we add in that we remove "09-localhost" client implementation. |
so I want to add these entries :
But I guess some of these (or all of these) might be irrelevant so I have to ask you |
yes please!
The only one I wouldn't include is:
|
Yeah, I'll apply the changes accordingly and be more descriptive with the entries |
thanks @catShaark! Closed by #1287 |
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local> Co-authored-by: Matthew Sevey <mjsevey@gmail.com> Co-authored-by: Manav Aggarwal <manavaggarwal1234@gmail.com>
Summary
The migration document should clearly explain how to go from the old 02-client API to the new API
For Admin Use
The text was updated successfully, but these errors were encountered: