Skip to content

Proposal messages are missing cosmos_proto.implements_interface option #1739

@pyramation

Description

@pyramation

Summary

related to cosmos-sdk issue here

in ADR 019 it states

In .proto files:
fields which accept interfaces should be annotated with cosmos_proto.accepts_interface using the same full-qualified name passed as protoName to InterfaceRegistry.RegisterInterface
interface implementations should be annotated with cosmos_proto.implements_interface using the same full-qualified name passed as protoName to InterfaceRegistry.RegisterInterface

In the future, protoName, cosmos_proto.accepts_interface, cosmos_proto.implements_interface may be used via code generation, reflection &/or static linting.

We're doing codegen, and we're missing many of the cosmos_proto.implements_interface: hyperweb-io/telescope#118 (comment)

If we can add these into the protos, it would help the codegen flow to make client-side serialization better.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions