-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor IBC message handling #19
Comments
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this issue
Nov 6, 2023
10 tasks
Adding self, will address after changes from eureka/port-refactor have settled and ideally will be able to target main. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The message server integration came last minute before the original 0.40.0 rc was cut. This left the IBC code a little bit in a disarray since it integrated the message server without reworking our internals which heavily relied on the previous SDK handler design. We have like 2 layers of redirects right now and structs that are being created and then never used, such as sdk.Result.
This may become problematic since it is hard to understand what each layer is doing here. There should really only be 2 layers, 1 for entry point from the SDK app, the second should be contained in the sub module itself. That is, a create client message, should enter the IBC handler at the top level and then it should go directly to the sub-module message server (02-client/keeper/msg_server.go). The IBC keeper shouldn't house all the message server itself, it doesn't add any benefit.
For Admin Use
The text was updated successfully, but these errors were encountered: