chore: adding assertion of channel capabilities migration #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cosmos/ibc-go into damian/ics27-chan-capability-migrations
|
Opening initially as draft. Happy path tests on this require #2033. |
Base automatically changed from
damian/ics27-chan-capability-migrations
to
main
August 31, 2022 10:42
colin-axner
reviewed
Aug 31, 2022
modules/apps/27-interchain-accounts/controller/keeper/migrations.go
Outdated
Show resolved
Hide resolved
damiannolan
commented
Sep 1, 2022
|
|
||
| // AssertChannelCapabilityMigrations checks that all channel capabilities generated using the interchain accounts controller port prefix | ||
| // are owned by the controller submodule and ibc. | ||
| func (m Migrator) AssertChannelCapabilityMigrations(ctx sdk.Context) error { |
There was a problem hiding this comment.
I'm open to suggestions on improving the name of this method.
damiannolan
requested review from
seantking,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
- Coverage 79.48% 79.47% -0.02%
==========================================
Files 173 174 +1
Lines 12011 12029 +18
==========================================
+ Hits 9547 9560 +13
- Misses 2042 2045 +3
- Partials 422 424 +2
|
|
I believe we also need to call |
3 tasks
colin-axner
approved these changes
Sep 6, 2022
modules/apps/27-interchain-accounts/controller/keeper/migrations_test.go
Show resolved
Hide resolved
Makes sense to me. And if the chain removes the underlying app entirely, those middleware enabled checks won't be reached since the underlyingApp != nil check comes first |
AdityaSripal
approved these changes
Sep 7, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* wip initial commit * draft migration completed * removing unnecessary storekey arg * additional cleanup * adding updates to migrations and tests additional assertions * updating and moving migrations code * adding additional checks to tests * cleaning up tests * cleaning up tests * updating inline doc comments, checking err return * using InitMemStore in favour of InitializeCapability, adjusting tests * adding assertion of channel capabilities migration * adapting migration code to use get/authenticate capability * adding changelog * updating tests * set middleware enabled for existing channels * assert middleware enabled in tests * updating changelog with middleware enabled flag (cherry picked from commit 8d56b94) # Conflicts: # CHANGELOG.md
damiannolan
added a commit
that referenced
this pull request
Sep 8, 2022
…2140) (#2219) * chore: adding assertion of channel capabilities migration (#2140) * wip initial commit * draft migration completed * removing unnecessary storekey arg * additional cleanup * adding updates to migrations and tests additional assertions * updating and moving migrations code * adding additional checks to tests * cleaning up tests * cleaning up tests * updating inline doc comments, checking err return * using InitMemStore in favour of InitializeCapability, adjusting tests * adding assertion of channel capabilities migration * adapting migration code to use get/authenticate capability * adding changelog * updating tests * set middleware enabled for existing channels * assert middleware enabled in tests * updating changelog with middleware enabled flag (cherry picked from commit 8d56b94) # Conflicts: # CHANGELOG.md * resolving conflicts Co-authored-by: Damian Nolan <damiannolan@gmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes