-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Metadata field in ICS20 Packet data proto #2411
Comments
I can take this up |
Lmk the versions for protoc & protoc-gen-go to generate updated pb.go |
Some context: Typically changing the packet data changes the packet commitment hash. This is actually not the primary concern of this change since the receiving chain will verify that the data bytes provided by the relayer were committed to by the sending chain. The concern is the receiving chains ability to decode the packet data. In this situation, a receiving chain without the memo field in the ICS20 packet data will fail to unmarshal the packet data and return an acknowledgement error. If the sending chain does not support the new field, it will also return an error if a user attempts to provide a MsgTransfer with the field included. Protobuf will not encode fields if they are empty. Thus transfers to chains without the new packet data field can continue to successfully occur so long as the memo field is left empty |
is there any reason to call it Memo over Metadata? |
PR is open in spec repo and calls it |
Introduce Metadata field in ICS20 Packet Data proto. This should be done with new field number so that it is backwards compatible
The text was updated successfully, but these errors were encountered: