Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create host and controller submodules #290

Closed
3 tasks
colin-axner opened this issue Jul 22, 2021 · 7 comments
Closed
3 tasks

Create host and controller submodules #290

colin-axner opened this issue Jul 22, 2021 · 7 comments
Assignees
@damiannolan
Labels
27-interchain-accounts type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
Interchain Accounts

Comments

@colin-axner
Copy link
Contributor

Summary

It can be difficult to understand which handlers belong to host and which to controller. The keeper package should have two files, host.go and controller.go. For example, InitInterchainAccount should go in controller.go. I'm fine with moving or leaving the handshakes as well

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the Interchain Accounts milestone Jul 22, 2021
@colin-axner
Copy link
Contributor Author

@damiannolan @seantking thoughts on creating sub-modules controller and host - in the same way ccv has child and parent?

@damiannolan
Copy link
Member

Yep, I think it's a nicer separation than just two different go files in the same pkg! 👍

@seantking
Copy link
Contributor

seantking commented Oct 7, 2021 •
edited
Loading

Yeap I like the idea a lot. Are there any downsides?

I started work on this but I wasn't sure if we needed to get the ICA middleware PR merged in first. Happy for others to pick this up 👍

@colin-axner
Copy link
Contributor Author

Might be good to wait until the end since this is mostly just moving code around

I'm not aware of any downsides at the moment

@colin-axner
Copy link
Contributor Author

Split genesis as well

@colin-axner colin-axner changed the title Create host.go and controller.go files in ICA keeper Create host and controller submodules Oct 13, 2021
@AdityaSripal
Copy link
Member

Agreed with this approach. I do the same thing for CCV. The parent and child modules are separated rather than keeping it in the same ibc module.

https://github.com/cosmos/interchain-security

@damiannolan damiannolan added 27-interchain-accounts type: code hygiene Clean up code but without changing functionality or interfaces labels Nov 5, 2021
This was referenced Nov 11, 2021
Closed
Merged
@damiannolan
Copy link
Member

closed by #541

@crodriguezvega crodriguezvega moved this to Done in ibc-go Dec 30, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@ethanfrey
Merge pull request cosmos#290 from CosmWasm/check-iavl-range-bounds
ff37dc6 
Check iavl range bounds
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
@jackzampolin
Fix denom issues (cosmos#290)
0674074 
* WIP debugging denoms

* Query valset at height broken example

* Add locks pretty much everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
27-interchain-accounts type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

No branches or pull requests
4 participants
@damiannolan @seantking @AdityaSripal @colin-axner