ICA OnChanOpenAck fixes

[colin-axner]

Summary

• matches spec (missing version check)
• test active channel is correctly set

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[seantking]

We don't actually pass Version into the ack step. We have access to the counter-party version but is it even necessary to check this? Maybe it should be removed from the spec.

[colin-axner]

We don't actually pass Version into the ack step. We have access to the counter-party version but is it even necessary to check this? Maybe it should be removed from the spec.

Yes it is. The version set on our end is the counterpartyVersion, thus it must match our required version. Otherwise we may run into issues later if we try to create a new version and existing channels have random version strings

[seantking]

Right ok, gotcha. Thanks 👍

Agree, let's add it. Secondary thought: if we end up going with the approach whereby we pass the address back as the version string, could this become somewhat less necessary? Or perhaps we pass back a version like ics27-1-{interchain-account address}

[colin-axner]

Yup, the version string should be something like ics27-1-{interchain-account address}. It could also be a protobuf definition with a Version and AccountAddress field, in which case we still want to check the application version