Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend TimeoutPacket to allow timeouts during an upgrade. #4080

Closed
3 tasks
DimitrisJim opened this issue Jul 13, 2023 · 0 comments
Closed
3 tasks

Amend TimeoutPacket to allow timeouts during an upgrade. #4080

DimitrisJim opened this issue Jul 13, 2023 · 0 comments
Assignees
Labels
channel-upgradability Channel upgradability feature

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jul 13, 2023

Summary

Allow packets to be timed out on a channel undergoing an upgrade.

Problem Definition

It currently isn't possible to timeout a packet due to the following condition:

if channel.State != types.OPEN {
return errorsmod.Wrapf(
types.ErrInvalidChannelState,
"channel state is not OPEN (got %s)", channel.State.String(),
)
}

Spec doesn't have this condition, probably due to the initial support for optimistic sends.

Based on my understanding, this condition should match that for AcknowledgePacket which is disallowing it to timeout if channel.State != OPEN && channel.FlushStatus != FLUSHING (i.e only OPEN channels or channels in TRYUPGRADE/ACKUPGRADE that are currently flushing are actually allowed).


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added the channel-upgradability Channel upgradability feature label Jul 13, 2023
@DimitrisJim DimitrisJim added this to the 04-channel upgrades alpha milestone Jul 13, 2023
@DimitrisJim DimitrisJim changed the title Amend TimeoutPacket to allow time outs during an upgrade. Amend TimeoutPacket to allow timeouts during an upgrade. Jul 13, 2023
@DimitrisJim DimitrisJim added the needs discussion Issues that need discussion before they can be worked on label Jul 13, 2023
@crodriguezvega crodriguezvega removed the needs discussion Issues that need discussion before they can be worked on label Jul 31, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jul 31, 2023
@DimitrisJim DimitrisJim self-assigned this Aug 7, 2023
@DimitrisJim DimitrisJim moved this from Todo to In progress in ibc-go Aug 16, 2023
@DimitrisJim DimitrisJim moved this from In progress to In review in ibc-go Aug 16, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

2 participants