Handle upgrading channels in TimeoutPacket. #4138
Conversation
DimitrisJim
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
| @@ -83,10 +83,10 @@ func (k Keeper) TimeoutPacket( | |||
| return types.ErrNoOpMsg | |||
| } | |||
|
|
|||
| if channel.State != types.OPEN { | |||
| if channel.State != types.OPEN && channel.FlushStatus != types.FLUSHING { | |||
There was a problem hiding this comment.
rejects all channels that aren't OPEN and that are not currently flushing (which leaves us with TRYUPGRADE and ACKUPGRADE in a FLUSHING state allowed to timeout packets).
| err = path.EndpointA.UpdateClient() | ||
| suite.Require().NoError(err) | ||
|
|
||
| // Move channel to TRYUPGRADE and to FLUSH_COMPLETE manually. |
There was a problem hiding this comment.
due to the positioning of the check in TimeoutPacket (after we check if len(commitment) == 0 it doesn't seem feasable we can check the combination [TRYUPGRADE/FLUSHCOMPLETE] w/o setting them manually.
There was a problem hiding this comment.
lgtm for this version! although i think this logic may need to get updated wrt spec changes 🙈
Ah, yeah. It appears most will 😄 |
|
Think it might be worth to close for now and wait for the updates. Will keep issue open to keep track of it ⚜️ |
Description
closes: #4080
Commit Message / Changelog Entry
Handle upgrading channels in TimeoutPacket.see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.