Release v4.5

[crodriguezvega]

• Branch off release/v4.5.x from release/v4.4.x.
• Bump ics23 to v0.10.0 in release/v4.5.x
• Bump ics23 to v0.9.1 (release of v0.9.x with this PR) in release/4.5.x.
• Run compatibility tests.
• Tag release.

[hdevalence]

Bumping this -- would it be possible to tag a release soon?

[crodriguezvega]

@hdevalence We had some issues integrating ics23 v0.10.0 into the v4 release line last week because v0.10.0 also migrated from gogo/protobuf to cosmos/gogoproto. We discussed this morning a work around and we are going to try to cherry pick and backport the prehash_compare_key PR into the release/v0.9.x of ics23. If I have a branch or tag this evening, would you be able to integrate into in some test environment and let us know if it works? Thank you!

[hdevalence]

Sure, we'd be happy to assist any way we can. Thank you!

[avahowell]

I was able to pull this commit into an osmosis localnet, using this replace directive in go.mod

replace (
	// osmosis-patched wasmd.
	github.com/CosmWasm/wasmd => github.com/osmosis-labs/wasmd v0.31.0-osmo-v16
	// Security patch for wasmvm. See https://github.com/CosmWasm/advisories/blob/main/CWAs/CWA-2023-002.md
	github.com/CosmWasm/wasmvm => github.com/CosmWasm/wasmvm v1.2.3

	// dragonberry
	//	github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v0.8.0
	// Our cosmos-sdk branch is:  https://github.com/osmosis-labs/cosmos-sdk, current branch: osmosis-main. Direct commit link: https://github.com/osmosis-labs/cosmos-sdk/commit/05346fa12992
	github.com/cosmos/cosmos-sdk => github.com/osmosis-labs/cosmos-sdk v0.45.0-rc1.0.20230908065430-05346fa12992

	// N.B. v0.19.5 contains a breaking change to the IAVL API
	github.com/cosmos/iavl v0.19.5 => github.com/cosmos/iavl v0.19.4

	// TEST 4.5
	github.com/cosmos/ibc-go/v4 => github.com/cosmos/ibc-go/v4 0f799562aef00c60cd611e3d849fc5a07a0e62ee 

	// use cosmos-compatible protobufs
	github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

	// Informal Tendermint fork
	github.com/tendermint/tendermint => github.com/informalsystems/tendermint v0.34.24
	// use grpc compatible with cosmos protobufs
	google.golang.org/grpc => google.golang.org/grpc v1.33.2
)

(note that i commented out the replace for ICS23, since i think the cherrypicked commit includes the dragonberry fix. please verify this)

I ran the osmosis localnet with the make localnet-* osmosis scripts, funded a hermes relayer, and used our hermes relayer fork with the PrehashKeyBeforeComparison: true proofspec. I was able to successfully open channels with a penumbra devnet, where before the handshake would fail due to an unknown field.

[crodriguezvega]

Thank you for testing, @avahowell. Happy to hear that this is working!

since i think the cherrypicked commit includes the dragonberry fix. please verify this

Yes, the release/v0.9.x branch of ics23 includes the dragonberry fix.

I will proceed to tag the releases. We should have v4.5 ready by the end of the week.

[crodriguezvega]

Green compatibility tests before RC0.

[hdevalence]

Awesome! Thanks for your work on this.

[crodriguezvega]

Closed by https://github.com/cosmos/ibc-go/releases/tag/v4.5.0.