-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump ics23 from v0.9.0 to v0.9.1 #2585
Conversation
I believe the CI is failing here because of this issue:
Note that there is an impending ICS23 0.9.1 release that includes the spec changes but keeps a compatible protobuf impl: https://github.com/cosmos/ics23/releases/tag/untagged-4eefd809a9cc10832e3f |
Thanks for the context. I hadn't yet looked into it that deeply
Do you know when that release will be? We are very close to finalising v1 so there's uncertainty around whether such a change is possible EDIT: I see they've just cut it (https://github.com/cosmos/ics23/releases/tag/go%2Fv0.9.1) |
Codecov Report
@@ Coverage Diff @@
## main #2585 +/- ##
==========================================
- Coverage 20.64% 20.63% -0.02%
==========================================
Files 132 133 +1
Lines 15335 15344 +9
==========================================
Hits 3166 3166
- Misses 11866 11875 +9
Partials 303 303 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @avahowell and @cmwaters !
ref: #2579