Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Split module.go and ibc_module.go for all app modules #472

Closed
AdityaSripal opened this issue Oct 7, 2021 · 0 comments · Fixed by #517
Closed

Refactor: Split module.go and ibc_module.go for all app modules #472

AdityaSripal opened this issue Oct 7, 2021 · 0 comments · Fixed by #517
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@AdityaSripal
Copy link
Member

This makes life a lot easier if you want to register the ibc module multiple times in ibc router (for different stacks). So we should just adopt this as a standard.

It also is much cleaner imo then having every important function of a module in the same file.

@AdityaSripal AdityaSripal added the good first issue Good for newcomers label Oct 7, 2021
@damiannolan damiannolan self-assigned this Nov 3, 2021
@crodriguezvega crodriguezvega added this to the v2.0.1 milestone Nov 9, 2021
@crodriguezvega crodriguezvega modified the milestones: v2.0.1, v3.0.0 Nov 17, 2021
@crodriguezvega crodriguezvega modified the milestones: v3.0.0, v2.1.0-rc0 Nov 29, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants