Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new port router for OnChanUpgradeTry #7027

Closed
3 tasks
colin-axner opened this issue Aug 1, 2024 · 3 comments
Closed
3 tasks

Use new port router for OnChanUpgradeTry #7027

colin-axner opened this issue Aug 1, 2024 · 3 comments
Assignees
@chatton
Labels
feat: port-router
Milestone
05-port refactor ...

Comments

@colin-axner
Copy link
Contributor

Summary

  • requires OnChanOpenInit to be implemented first
  • relayer provided versions as a map from app name to version
  • implement legacyibcmodule OnChanUpgradeTry
  • use wrap version interface to glue back together versions
  • modify apps to remove im.app references

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the 05-port refactor alpha milestone Aug 1, 2024
@colin-axner colin-axner moved this to On hold ❌ in ibc-go Aug 1, 2024
@chatton chatton self-assigned this Aug 7, 2024
@chatton
Copy link
Contributor

chatton commented Aug 7, 2024

I believe we are no longer going with the second bullet point

relayer provided versions as a map from app name to version

please correct me if I'm wrong!

@colin-axner
Copy link
Contributor Author

correct!

This was referenced Aug 7, 2024
Merged
Merged
@colin-axner colin-axner moved this from On hold ❌ to In review 👀 in ibc-go Aug 8, 2024
@chatton
Copy link
Contributor

chatton commented Aug 8, 2024

closed by #7092

@chatton chatton closed this as completed Aug 8, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
feat: port-router
Projects
ibc-go
Status: Done 🥳
Milestone
05-port refactor alpha
Development

No branches or pull requests
2 participants
@chatton @colin-axner