Use new port router for onchanupgradetry #7067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
damiannolan,
srdtrk,
DimitrisJim,
crodriguezvega,
gjermundgaraba and
bznein
as code owners
chatton
commented
Aug 7, 2024
| @@ -74,6 +74,50 @@ func (im *LegacyIBCModule) OnChanOpenInit( | |||
| return reconstructVersion(im.cbs, negotiatedVersions) | |||
| } | |||
|
|
|||
| // OnChanOpenTry implements the IBCModule interface. | |||
| func (im *LegacyIBCModule) OnChanOpenTry( | |||
There was a problem hiding this comment.
this is almost an exact duplicate, I played around with trying to generalize the Init/Try functions, but it ended up looking even uglier, happy to revisit this idea, but I think it's fine as is for now unless someone has a suggestion for removing the duplication.
|
colin-axner
reviewed
Aug 7, 2024
| // lower down in the stack. Thus, if it is not a fee version we pass the entire version string onto the underlying | ||
| // application. | ||
| return im.app.OnChanOpenTry(ctx, order, connectionHops, portID, channelID, counterparty, counterpartyVersion) | ||
| if strings.TrimSpace(counterpartyVersion) != "" && counterpartyVersion != types.Version { |
There was a problem hiding this comment.
Suggested change
| if strings.TrimSpace(counterpartyVersion) != "" && counterpartyVersion != types.Version { | |
| if counterpartyVersion != types.Version { |
There was a problem hiding this comment.
I think on Try, the version must be set
colin-axner
approved these changes
Aug 7, 2024
chatton
deleted the
cian/issue#7027-use-new-port-router-for-onchanupgradetry
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marking as R4R for E2Es
closes: #7027
This PR refactors fee middleware, ICA and callbacks to use the new port router.
Some wiring changes in app.gos needed to be fixed also.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.