Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EscrowPacketFee additional checks #752

Closed
2 of 6 tasks
seantking opened this issue Jan 18, 2022 · 3 comments
Closed
2 of 6 tasks

EscrowPacketFee additional checks #752

seantking opened this issue Jan 18, 2022 · 3 comments
Assignees
@damiannolan
Labels
29-fee
Milestone
Fee middleware beta

Comments

@seantking
Copy link
Contributor

seantking commented Jan 18, 2022 •
edited by colin-axner
Loading

Summary

EscrowPacketFee should:

  • not overwrite existing incentivized packets
  • allow adding to an existing escrow for incentivizing a packet
  • check if the packet has been acknowledged or timed out

Tests will need to be updated accordingly.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking self-assigned this Jan 18, 2022
@colin-axner
Copy link
Contributor

As discussed during the internal audit, "not allow a different account than the refund address to add to the escrow" is no longer relevant. We will try to support this functionality

@seantking
Copy link
Contributor Author

Updated the issue 👍

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jan 24, 2022
@damiannolan damiannolan self-assigned this Feb 8, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Feb 8, 2022
@damiannolan damiannolan mentioned this issue Feb 9, 2022
Closed
9 tasks
@seantking seantking moved this from In progress to Done in ibc-go Feb 16, 2022
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@alpe
Merge pull request cosmos#752 from loloicci/missing-colon
e0e6cc4 
Add missing colons in String of some proposals
@colin-axner
Copy link
Contributor

last change to be made is duplicate of #1318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
Development

No branches or pull requests
4 participants
@damiannolan @crodriguezvega @seantking @colin-axner