Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nits: comments #771

Closed
5 of 9 tasks
seantking opened this issue Jan 19, 2022 · 0 comments
Closed
5 of 9 tasks

Nits: comments #771

seantking opened this issue Jan 19, 2022 · 0 comments
Labels
29-fee good first issue Good for newcomers
Milestone
Fee middleware alpha

Comments

@seantking
Copy link
Contributor

seantking commented Jan 19, 2022 •
edited
Loading

Summary

  • Add comment explaining discarding the boolean value in WriteAcknowledgement
  • Remove comment in DistributePacketFeeOnTimeout
  • Add godoc for InitGenesis and ExportGenesis
  • Remove commented line from GenerateGenesisState in module.go
  • Uncomment types.RegisterQueryServer in module.go
  • Fix code comment in distributeFee. Distribute fee is not just distributing to reverse relayer

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking added good first issue Good for newcomers 29-fee labels Jan 19, 2022
@seantking seantking added this to the Fee Middleware milestone Jan 19, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 20, 2022
@seantking seantking mentioned this issue Feb 11, 2022
Merged
9 tasks
@seantking seantking moved this from Backlog to In review in ibc-go Feb 11, 2022
Repository owner moved this from In review to Done in ibc-go Feb 15, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@nashqueue
Refactor: Header -> Signed Header (cosmos#771)
4039cbe 
Fixes: cosmos#773

---------

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
29-fee good first issue Good for newcomers
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
1 participant
@seantking