Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing grpc queries to handle multiple packet fees #953

Closed
2 tasks done
crodriguezvega opened this issue Feb 21, 2022 · 1 comment
Closed
2 tasks done

Update existing grpc queries to handle multiple packet fees #953

crodriguezvega opened this issue Feb 21, 2022 · 1 comment
Assignees
Labels

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Feb 21, 2022

Summary

  • Update IncentivizedPackets query to return packet fees for the given paginated request under the FeesInEscrowPrefix key
  • Update IncentivizedPacket query to return []PacketFee and associated PacketId

The above relies on models changed expected in #760

// PacketFee contains the relayer fee, refund address and an optional list of relayers that are permitted to receive the
// fee
message PacketFee {
  Fee             fee            = 1 [(gogoproto.nullable) = false];
  string          refund_address = 2 [(gogoproto.moretags) = "yaml:\"refund_address\""];
  repeated string relayers       = 3;
}

// PacketFees contains a list of type PacketFee
message PacketFees {
  repeated PacketFee packet_fees = 1 [(gogoproto.moretags) = "yaml:\"packet_fees\"", (gogoproto.nullable) = false];
}

// IdentifiedPacketFees contains a PacketFree and associated PacketId
message IdentifiedPacketFees {
  ibc.core.channel.v1.PacketId packet_id = 1
      [(gogoproto.nullable) = false, (gogoproto.moretags) = "yaml:\"packet_id\""];
  repeated PacketFee packet_fees = 2 [(gogoproto.moretags) = "yaml:\"packet_fees\"", (gogoproto.nullable) = false];
}
@crodriguezvega crodriguezvega added this to the Fee Middleware milestone Feb 21, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Feb 21, 2022
@crodriguezvega crodriguezvega moved this from Todo to Backlog in ibc-go Feb 21, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Feb 21, 2022
@damiannolan
Copy link
Member

Updated with relevant content!

@damiannolan damiannolan moved this from Todo to In progress in ibc-go Feb 22, 2022
@damiannolan damiannolan moved this from In progress to In review in ibc-go Feb 22, 2022
Repository owner moved this from In review to Done in ibc-go Feb 24, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
We have made a breaking change in node v0.10.0 regarding data requests.
celestiaorg/celestia-node@62a0b97

Previously, a "data not found" meant both "the node failed to retrieve
that data, please retry" as well as "the node retrieved the data
successfully, but your namespace is not included in the data". We have
split these errors, so now we have an `ErrNamespaceNotFound` which
indicates a successful request for empty data.

I have no idea how to test rollkit so would love some help on getting
that set up

---------

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants