Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pr introducing pack/unpack acknowledgements #968

Closed
3 tasks
colin-axner opened this issue Feb 22, 2022 · 0 comments · Fixed by #973
Closed
3 tasks

Revert pr introducing pack/unpack acknowledgements #968

colin-axner opened this issue Feb 22, 2022 · 0 comments · Fixed by #973
Assignees

Comments

@colin-axner
Copy link
Contributor

Summary

Since acknowledgements cannot wrap underlying acknowledgements as Any's, we should revert this pr #895


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner self-assigned this Feb 22, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
## Overview

The Code Coverage action appears to be broken, this is an attempt to fix
it.

Fix inspired by
https://github.com/celestiaorg/celestia-node/pull/2249/files

## Checklist

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Connor O'Hara <connor@switchboard.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant