IBC Testing Package v2 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Apr 9, 2021
colin-axner
changed the title
|
The IBC testing refactor will be a multi part refactor. Part 1 introduces the new design of the testing package
Part 2 refactor tests to use the new design and remove all the old functions Part 3 will implement a TestingApp interface so outside repos can use the testing package Part 4 will update docs and do polishing as needed |
|
I've tested that |
colin-axner
commented
Apr 13, 2021
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 65.22% 63.79% -1.43%
==========================================
Files 127 130 +3
Lines 8413 8601 +188
==========================================
Hits 5487 5487
- Misses 2561 2749 +188
Partials 365 365
|
colin-axner
changed the title
AdityaSripal
requested changes
Apr 13, 2021
colin-axner
commented
Apr 15, 2021
AdityaSripal
requested changes
Apr 15, 2021
* remove old testing code, update light client tests, update part of transfer tests * fix transfer tests * remove old code from testing package * refactor 02-client tests * refactor 03-connection * all tests passing * self review fixes * ignore testing package for codecov * Update modules/core/03-connection/keeper/verify_test.go
* IBCKeeper reference into an interface function * move to testing app interface wip * add rest of interface functions, fix tests * finish making testing app modular
colin-axner
changed the title
AdityaSripal
approved these changes
Apr 21, 2021
* update README * test modularity with transfer, update README, minor fixes
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
Bumps [github.com/pelletier/go-toml](https://github.com/pelletier/go-toml) from 1.9.3 to 1.9.4. - [Release notes](https://github.com/pelletier/go-toml/releases) - [Commits](pelletier/go-toml@v1.9.3...v1.9.4) --- updated-dependencies: - dependency-name: github.com/pelletier/go-toml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #106
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes