isolate packet fee distribution for on acknowledgement and on timeout into separate functions #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th acknowledgement and timeout distribution
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
damiannolan
approved these changes
Apr 13, 2022
Codecov Report
@@ Coverage Diff @@
## main #1253 +/- ##
=======================================
Coverage 80.15% 80.16%
=======================================
Files 166 166
Lines 11943 11949 +6
=======================================
+ Hits 9573 9579 +6
Misses 1912 1912
Partials 458 458
|
seantking
approved these changes
Apr 14, 2022
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
… 0.12.0 (cosmos#1253) Bumps [github.com/multiformats/go-multiaddr](https://github.com/multiformats/go-multiaddr) from 0.11.0 to 0.12.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/multiformats/go-multiaddr/releases">github.com/multiformats/go-multiaddr's releases</a>.</em></p> <blockquote> <h2>v0.12.0</h2> <h2>What's Changed</h2> <ul> <li>ci: uci/delete-templates by <a href="https://github.com/web3-bot"><code>@web3-bot</code></a> in <a href="https://redirect.github.com/multiformats/go-multiaddr/pull/215">multiformats/go-multiaddr#215</a></li> <li>ci: uci/copy-templates by <a href="https://github.com/web3-bot"><code>@web3-bot</code></a> in <a href="https://redirect.github.com/multiformats/go-multiaddr/pull/216">multiformats/go-multiaddr#216</a></li> <li>ci: uci/copy-templates by <a href="https://github.com/web3-bot"><code>@web3-bot</code></a> in <a href="https://redirect.github.com/multiformats/go-multiaddr/pull/217">multiformats/go-multiaddr#217</a></li> <li>net: consider dns addresses as public by <a href="https://github.com/sukunrt"><code>@sukunrt</code></a> in <a href="https://redirect.github.com/multiformats/go-multiaddr/pull/220">multiformats/go-multiaddr#220</a></li> <li>net: consider /dns/localhost as private address by <a href="https://github.com/sukunrt"><code>@sukunrt</code></a> in <a href="https://redirect.github.com/multiformats/go-multiaddr/pull/221">multiformats/go-multiaddr#221</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/multiformats/go-multiaddr/compare/v0.11.0...v0.12.0">https://github.com/multiformats/go-multiaddr/compare/v0.11.0...v0.12.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/multiformats/go-multiaddr/commit/5dd793c6fc4935fad347429a48a168acc8073474"><code>5dd793c</code></a> release v0.12.0 (<a href="https://redirect.github.com/multiformats/go-multiaddr/issues/223">#223</a>)</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/f9a66bc382da9f5f5b319bd0d2beae7f63a253be"><code>f9a66bc</code></a> net: consider /dns/localhost as private address (<a href="https://redirect.github.com/multiformats/go-multiaddr/issues/221">#221</a>)</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/a12495439b7098bf1d3542b720fc6b0a7ca51b85"><code>a124954</code></a> net: consider dns addresses as public (<a href="https://redirect.github.com/multiformats/go-multiaddr/issues/220">#220</a>)</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/dfafc5928d51cb73d8e8347adc5f0b4babc897ca"><code>dfafc59</code></a> chore: bump go.mod to Go 1.20 and run go fix (<a href="https://redirect.github.com/multiformats/go-multiaddr/issues/217">#217</a>)</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/92a246dbc17f0a40027ce55fc1897c3797455e87"><code>92a246d</code></a> Merge pull request <a href="https://redirect.github.com/multiformats/go-multiaddr/issues/216">#216</a> from multiformats/uci/copy-templates</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/db92edd85124f05554bd78f4cb910e3c0cde5b88"><code>db92edd</code></a> chore: add or force update .github/workflows/tagpush.yml</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/438fa2383eeaf8c19c96da7107738044f3955752"><code>438fa23</code></a> chore: add or force update .github/workflows/release-check.yml</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/841bae1eb4184543fc061c8b2b5d39dadf7db7fa"><code>841bae1</code></a> chore: add or force update .github/workflows/releaser.yml</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/9bfab28ef3a3233cd3e2880557f06620c552e73a"><code>9bfab28</code></a> chore: add or force update .github/workflows/go-check.yml</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/aeaad918987fa7783e45bc496ba9329686fb410a"><code>aeaad91</code></a> chore: add or force update .github/workflows/go-test.yml</li> <li>Additional commits viewable in <a href="https://github.com/multiformats/go-multiaddr/compare/v0.11.0...v0.12.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ganesha Upadhyaya <ganeshrvce@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces the complexity contained in
DistributePacketFeesandDistributePacketFeesOnAcknowledgementin anticipation of #1251closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes