refactor: emit cumulative fees when incentivizing a packet multiple times #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
+ Coverage 80.35% 80.37% +0.01%
==========================================
Files 166 166
Lines 12083 12094 +11
==========================================
+ Hits 9709 9720 +11
Misses 1918 1918
Partials 456 456
|
crodriguezvega
approved these changes
May 17, 2022
damiannolan
reviewed
May 18, 2022
modules/apps/29-fee/keeper/events.go
Outdated
Comment on lines
24
to
26
| totalRecvFees.Add(fee.Fee.RecvFee...) | ||
| totalAckFees.Add(fee.Fee.AckFee...) | ||
| totalTimeoutFees.Add(fee.Fee.TimeoutFee...) |
There was a problem hiding this comment.
Should we reassign as coins.Add(...) returns sdk.Coins?
totalRecvFees = totalRecvFees.Add(...)
// ...etc
I think this needs to be done for the singular coin.Add() function. Not 100% sure about Coins but may be good practise to keep consistent and handle return value.
There was a problem hiding this comment.
seems like a good idea to me
There was a problem hiding this comment.
nice catch 🐛 - the tests were using an expected value of "", the lack of reassigning didn't change the variable values
…bc-go into colin/1327-emit-cumulative-fees
seantking
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1327
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes