-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ica controller middleware error typo #1419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hea9549! 👍
We should probably delete the comment on line 176.
|
0fad2d2
to
9413763
Compare
@seantking apply your comment :) good point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙏
Codecov Report
@@ Coverage Diff @@
## main #1419 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 166 166
Lines 12081 12081
=======================================
Hits 9707 9707
Misses 1918 1918
Partials 456 456
|
Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 25767f6) # Conflicts: # modules/apps/27-interchain-accounts/controller/ibc_module.go
Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 25767f6) # Conflicts: # modules/apps/27-interchain-accounts/controller/ibc_module.go
Description
I think this error represent ICA controller error, not ICA-auth
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes