Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ica controller middleware error typo #1419

Merged
merged 3 commits into from
May 25, 2022

Conversation

hea9549
Copy link
Contributor

@hea9549 hea9549 commented May 24, 2022

Description

I think this error represent ICA controller error, not ICA-auth


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hea9549! 👍

@seantking
Copy link
Contributor

We should probably delete the comment on line 176.

// The ICA controller module builds the outgoing ICA packet and calls the core IBC SendPacket

@hea9549
Copy link
Contributor Author

hea9549 commented May 24, 2022

@seantking apply your comment :) good point

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@codecov-commenter
Copy link

Codecov Report

Merging #1419 (992b577) into main (abd577e) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1419   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files         166      166           
  Lines       12081    12081           
=======================================
  Hits         9707     9707           
  Misses       1918     1918           
  Partials      456      456           
Impacted Files Coverage Δ
...7-interchain-accounts/controller/ibc_middleware.go 87.03% <0.00%> (ø)
modules/apps/29-fee/types/msgs.go 89.77% <100.00%> (ø)

@crodriguezvega crodriguezvega merged commit 25767f6 into cosmos:main May 25, 2022
mergify bot pushed a commit that referenced this pull request May 25, 2022
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 25767f6)

# Conflicts:
#	modules/apps/27-interchain-accounts/controller/ibc_module.go
mergify bot pushed a commit that referenced this pull request May 25, 2022
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 25767f6)

# Conflicts:
#	modules/apps/27-interchain-accounts/controller/ibc_module.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants