-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding fee middleware tests for ics27 interchain accounts #1433
Conversation
…pport fee middleware functionality
Note this PR includes all the additions from #1432 as they're necessary to put the tests in place.
|
Codecov Report
@@ Coverage Diff @@
## main #1433 +/- ##
==========================================
- Coverage 80.29% 80.23% -0.07%
==========================================
Files 166 166
Lines 12143 12136 -7
==========================================
- Hits 9750 9737 -13
- Misses 1933 1941 +8
+ Partials 460 458 -2
|
modules/apps/29-fee/ica_test.go
Outdated
DefaultPortID, _ = icatypes.NewControllerPortID(DefaultOwnerAddress) | ||
|
||
// DefaultICAVersion defines a resuable interchainaccounts version string for testing purposes | ||
DefaultICAVersion = string(icatypes.ModuleCdc.MustMarshalJSON(&icatypes.Metadata{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be useful to create a helper function in types that creates the default ICA version given the connection IDs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅
modules/apps/27-interchain-accounts/controller/keeper/account.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great test! 👍
…ion, add comments and adjust assertions
Description
needs: #1432
closes: #1328
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes