Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement registered payee fee distribution #1526

Merged
merged 17 commits into from
Jun 17, 2022

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Jun 10, 2022

Description

  • Implementation of registered payee fee distribution for:
    • OnAcknowledgementPacket
    • OnTimeoutPacket
  • Refactoring and updating test cases, adding expResult and additional cases (registered payees, application cb failure)

closes: #1477


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #1526 (af201e0) into main (11297aa) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
+ Coverage   80.24%   80.29%   +0.05%     
==========================================
  Files         166      166              
  Lines       12252    12304      +52     
==========================================
+ Hits         9832     9880      +48     
- Misses       1956     1959       +3     
- Partials      464      465       +1     
Impacted Files Coverage Δ
modules/apps/29-fee/ibc_middleware.go 91.83% <100.00%> (+1.47%) ⬆️
modules/apps/29-fee/types/genesis.go 78.12% <0.00%> (-3.85%) ⬇️
modules/apps/29-fee/types/msgs.go 90.75% <0.00%> (ø)
modules/apps/29-fee/keeper/genesis.go 87.50% <0.00%> (ø)
modules/apps/29-fee/keeper/msg_server.go 96.00% <0.00%> (ø)
modules/apps/29-fee/types/codec.go 44.44% <0.00%> (+0.69%) ⬆️
modules/apps/transfer/types/trace.go 90.08% <0.00%> (+1.62%) ⬆️

@damiannolan damiannolan marked this pull request as ready for review June 13, 2022 14:48
@damiannolan damiannolan requested a review from chatton June 13, 2022 14:49
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test coverage! Just a small question, nice work 🥇

modules/apps/29-fee/ibc_middleware.go Show resolved Hide resolved
modules/apps/29-fee/ibc_middleware_test.go Outdated Show resolved Hide resolved
modules/apps/29-fee/ibc_middleware_test.go Outdated Show resolved Hide resolved
modules/apps/29-fee/ibc_middleware_test.go Outdated Show resolved Hide resolved
modules/apps/29-fee/ibc_middleware_test.go Outdated Show resolved Hide resolved
modules/apps/29-fee/ibc_middleware_test.go Show resolved Hide resolved
modules/apps/29-fee/ibc_middleware_test.go Outdated Show resolved Hide resolved
modules/apps/29-fee/ibc_middleware_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb work, @damiannolan, with the new payee feature and the refactor of the counterparty address. 🎸

Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work 🥇

@damiannolan damiannolan merged commit 9680cb9 into main Jun 17, 2022
@damiannolan damiannolan deleted the damian/1477-implement-payee-distribution branch June 17, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Relayers to overwrite payee address
5 participants