Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix solo machine as per ics spec changes #153

Merged
merged 4 commits into from
May 10, 2021

Conversation

colin-axner
Copy link
Contributor

Description

Implements proposed ICS spec changes

NOTE: Timeouts are currently not supported as outlined in this issue

closes: #119


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

Codecov Report

Merging #153 (fb937b1) into main (2c880a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   79.17%   79.18%           
=======================================
  Files         109      109           
  Lines        6526     6528    +2     
=======================================
+ Hits         5167     5169    +2     
  Misses       1004     1004           
  Partials      355      355           
Impacted Files Coverage Δ
...light-clients/06-solomachine/types/client_state.go 67.15% <100.00%> (+0.32%) ⬆️

@colin-axner colin-axner enabled auto-merge (squash) May 10, 2021 15:56
@colin-axner colin-axner merged commit 5991e86 into main May 10, 2021
@colin-axner colin-axner deleted the colin/119-sm-sequence-mismatch branch May 10, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBC ConnectionOpenAck fails for solo machine client
3 participants