Build simd images as part of the release process #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
tac0turtle
approved these changes
Jun 14, 2022
tac0turtle
reviewed
Jun 14, 2022
.github/workflows/build-simd.yml
Outdated
| @@ -0,0 +1,39 @@ | |||
| name: Create and publish simd Docker image | |||
|
|
|||
| on: workflow_dispatch | |||
There was a problem hiding this comment.
should we make this push to master/main also can make it on pull_request to test in the PR
There was a problem hiding this comment.
I can add on pull_request and then remove before merging, ideally we'll actually just want this is the release task.
damiannolan
approved these changes
Jun 14, 2022
|
@damiannolan since the build/push works as expected (the image appears here) I've moved the action into the release.yml file. Now any time we release an image of that tag will be built and pushed. |
chatton
deleted the
cian/issue#1531-build-simd-images-as-part-of-the-release-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task which needs to be run manually to build and push the simd docker image.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes