-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ics29 middleware usage for app devs #1567
Conversation
### Transfer | ||
|
||
See below for an example of how to create an application stack using `transfer` and `29-fee`. | ||
The in-line comments describe the execution flow of packets between the application stack and IBC core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a little bit confusing that you mention app.go two sections above but only show the code snippet here -- maybe either move the sentence from above "For Cosmos SDK chains this setup...." down to the start of this section or move the code snippet up somewhere closer, and indicate that the code snippet is from app.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also maybe mention a bit about the ordering of the middleware and how it will affect how the code is called (the bug from evmos)
-- this can also go into the main middleware docs but i dont think it hurts to repeat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to leave a reply here earlier... I added an extra sentence to each example section reiterating the app/app.go
direction. I feel the ordering is covered by the in line comments in the code snippets and should be covered in the middleware docs which are listed as {prereq}
reading.
We may want to review the middleware developer/integration docs also to make sure they are up to date!
|
||
# Integration | ||
|
||
Learn how to configure the Fee Middleware module with IBC applications. The following document only applies for Cosmos SDK chains. {synopsis} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe be explicit somewhere about who these docs are for -- cosmos SDK devs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean. Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Description
transfer
and29-fee
27-interchain-accounts
and29-fee
with associated auth module.ref: #1408
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes