Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructuring 07-tendermint lightclient directory layout #1677

Merged

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Jul 8, 2022

Description

  • Moves all go sources under 07-tendermint/types to 07-tendermint

ref: #124
closes: #124


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@@ -2,7 +2,7 @@ syntax = "proto3";

package ibc.lightclients.tendermint.v1;

option go_package = "github.com/cosmos/ibc-go/v3/modules/light-clients/07-tendermint/types";
option go_package = "github.com/cosmos/ibc-go/v3/modules/light-clients/07-tendermint;tendermint";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is key - note the ;tendermint suffix in order to override the package name in the generated .pb.go files.

Otherwise the tendermint.pb.go file would have a package definition of package _07_tendermint

Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 -- shouldnt we add a note that this is API breaking to the CHANGELOG?

* restructing 06-solomachine folder layout

* tidy go modules

* fixing dead link

* adding changelog entry
@damiannolan damiannolan merged commit 549c181 into 02-client-refactor Jul 12, 2022
@damiannolan damiannolan deleted the damian/124-modify-lightclient-folder-structure branch July 12, 2022 13:54
oshorefueled pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
…os#1677)

* restructuring 07-tendermint lightclient directory tree

* adding changelog entry

* chore: restructuring 06-solomachine lightclient directory layout (cosmos#1679)

* restructing 06-solomachine folder layout

* tidy go modules

* fixing dead link

* adding changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants