chore: restructuring 07-tendermint lightclient directory layout #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
fedekunze,
AdityaSripal,
crodriguezvega,
seantking and
charleenfei
as code owners
damiannolan
commented
Jul 8, 2022
| @@ -2,7 +2,7 @@ syntax = "proto3"; | |||
|
|
|||
| package ibc.lightclients.tendermint.v1; | |||
|
|
|||
| option go_package = "github.com/cosmos/ibc-go/v3/modules/light-clients/07-tendermint/types"; | |||
| option go_package = "github.com/cosmos/ibc-go/v3/modules/light-clients/07-tendermint;tendermint"; | |||
There was a problem hiding this comment.
This is key - note the ;tendermint suffix in order to override the package name in the generated .pb.go files.
Otherwise the tendermint.pb.go file would have a package definition of package _07_tendermint
charleenfei
approved these changes
Jul 8, 2022
colin-axner
approved these changes
Jul 12, 2022
* restructing 06-solomachine folder layout * tidy go modules * fixing dead link * adding changelog entry
oshorefueled
pushed a commit
to ComposableFi/ibc-go
that referenced
this pull request
Aug 9, 2022
…os#1677) * restructuring 07-tendermint lightclient directory tree * adding changelog entry * chore: restructuring 06-solomachine lightclient directory layout (cosmos#1679) * restructing 06-solomachine folder layout * tidy go modules * fixing dead link * adding changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
07-tendermint/typesto07-tendermintref: #124
closes: #124
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes