gofumpt to reduce total number of changes versus v5 #1734

faddat · 2022-07-19T20:52:25Z

Description

This is just a formatting change that will ease the review of v5.

This PR replaces #1717

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.5 to 2.2.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2.1.5...v2.2.0) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ctions/setup-go-2.2.0 build(deps): bump actions/setup-go from 2.1.5 to 2.2.0

crodriguezvega

Looks good to me! But just out of curiosity: what was wrong with the previous PR that you needed to open this new one?

modules/apps/29-fee/ibc_middleware.go

faddat · 2022-07-21T01:04:23Z

done :)

faddat · 2022-07-22T08:21:31Z

Looks good to me! But just out of curiosity: what was wrong with #1717 that you needed to open this new one?

It was accumulating cruft from merging main in.

At least, I think that's the reason.

faddat · 2022-07-22T08:59:16Z

I think it's set.

crodriguezvega · 2022-07-22T11:39:32Z

Do we still need this PR after we merge #1418? Or can this be closed then?

faddat · 2022-07-22T17:37:01Z

Either way really. You could merge this to make a final review of v5 easier, or merge v5 and you’d still get this.

codecov-commenter · 2022-07-22T17:56:27Z

Codecov Report

Merging #1734 (1288fb6) into main (af4e651) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1288fb6 differs from pull request most recent head 0929260. Consider uploading reports for the commit 0929260 to get more accurate results

@@            Coverage Diff             @@
##             main    #1734      +/-   ##
==========================================
- Coverage   80.04%   80.04%   -0.01%     
==========================================
  Files         166      166              
  Lines       12421    12419       -2     
==========================================
- Hits         9943     9941       -2     
  Misses       2013     2013              
  Partials      465      465

Impacted Files	Coverage Δ
cmd/build_test_matrix/main.go	`74.28% <ø> (ø)`
modules/apps/transfer/keeper/migrations.go	`93.10% <ø> (-0.23%)`	⬇️
modules/core/02-client/keeper/grpc_query.go	`68.20% <ø> (ø)`
modules/core/03-connection/keeper/handshake.go	`89.83% <ø> (-0.06%)`	⬇️
modules/apps/29-fee/ibc_middleware.go	`91.83% <100.00%> (ø)`

colin-axner

LGTM, just curious on why we should add gitpod?

colin-axner · 2022-07-25T10:28:07Z

.gitpod.yml

@@ -0,0 +1,9 @@
+# This configuration file was automatically generated by Gitpod.


Can you help me understand why this is useful? I'm not familiar with Gitpod

oh no I am sorry!

OK, so 1 bad thing about gitpod:

It puts these in repos automatically.

So I guess not seeing them in unrelated PR's could be a good reason to do it, but that's not really a good reason. Let me get into an actual good reason, after deleting this file.

sorry about this!

damiannolan

LGTM 🚀

concerns addressed

dependabot bot and others added 3 commits February 10, 2022 03:04

Merge pull request #14 from notional-labs/dependabot/github_actions/a…

3359732

…ctions/setup-go-2.2.0 build(deps): bump actions/setup-go from 2.1.5 to 2.2.0

gofumpt to reduce total number of changes versus v5

4f4f695

faddat requested review from AdityaSripal, seantking, charleenfei, colin-axner, damiannolan, fedekunze, crodriguezvega and chatton as code owners July 19, 2022 20:52

crodriguezvega previously requested changes Jul 20, 2022

View reviewed changes

modules/apps/29-fee/ibc_middleware.go Outdated Show resolved Hide resolved

faddat added 2 commits July 21, 2022 08:00

Merge branch 'main' into gofumpt-v4-for-v5

9beb567

change IncentivizeAcknowledgement to declaration

ce0609a

crodriguezvega mentioned this pull request Jul 21, 2022

🧹 Linting #1418

Merged

9 tasks

faddat added 3 commits July 21, 2022 18:03

Merge branch 'main' into gofumpt-v4-for-v5

f40134f

Merge branch 'main' into gofumpt-v4-for-v5

18e6fc5

ibc_middleware fix

a5bb536

Merge branch 'main' into gofumpt-v4-for-v5

46290bc

colin-axner reviewed Jul 25, 2022

View reviewed changes

Delete .gitpod.yml

670ddb4

sorry about this!

faddat mentioned this pull request Jul 25, 2022

Standardized Development Environment #1748

Closed

9 tasks

colin-axner approved these changes Jul 25, 2022

View reviewed changes

damiannolan approved these changes Jul 25, 2022

View reviewed changes

colin-axner requested a review from crodriguezvega July 26, 2022 08:02

Merge branch 'main' into gofumpt-v4-for-v5

cead589

colin-axner enabled auto-merge (squash) July 26, 2022 09:48

faddat added 4 commits July 27, 2022 02:15

Merge branch 'main' into gofumpt-v4-for-v5

abaa1c5

Merge remote-tracking branch 'origin/main' into gofumpt-v4-for-v5

85c867d

Merge remote-tracking branch 'upstream/main' into gofumpt-v4-for-v5

1288fb6

gofumpt -w -l .

0929260

auto-merge was automatically disabled July 27, 2022 14:02
Head branch was pushed to by a user without write access

colin-axner enabled auto-merge (squash) July 27, 2022 14:15

colin-axner merged commit 48c456d into cosmos:main Jul 27, 2022

faddat mentioned this pull request Aug 4, 2022

Tracking issue for V10 CosmosContracts/juno#235

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gofumpt to reduce total number of changes versus v5 #1734

gofumpt to reduce total number of changes versus v5 #1734

faddat commented Jul 19, 2022 •

edited

Loading

crodriguezvega left a comment

faddat commented Jul 21, 2022

faddat commented Jul 22, 2022 •

edited

Loading

faddat commented Jul 22, 2022

crodriguezvega commented Jul 22, 2022

faddat commented Jul 22, 2022

codecov-commenter commented Jul 22, 2022 •

edited

Loading

colin-axner left a comment

colin-axner Jul 25, 2022

faddat Jul 25, 2022

faddat Jul 25, 2022

damiannolan left a comment •

edited

Loading

		@@ -0,0 +1,9 @@
		# This configuration file was automatically generated by Gitpod.

gofumpt to reduce total number of changes versus v5 #1734

gofumpt to reduce total number of changes versus v5 #1734

Conversation

faddat commented Jul 19, 2022 • edited Loading

Description

crodriguezvega left a comment

Choose a reason for hiding this comment

faddat commented Jul 21, 2022

faddat commented Jul 22, 2022 • edited Loading

faddat commented Jul 22, 2022

crodriguezvega commented Jul 22, 2022

faddat commented Jul 22, 2022

codecov-commenter commented Jul 22, 2022 • edited Loading

Codecov Report

colin-axner left a comment

Choose a reason for hiding this comment

colin-axner Jul 25, 2022

Choose a reason for hiding this comment

faddat Jul 25, 2022

Choose a reason for hiding this comment

faddat Jul 25, 2022

Choose a reason for hiding this comment

damiannolan left a comment • edited Loading

Choose a reason for hiding this comment

faddat commented Jul 19, 2022 •

edited

Loading

faddat commented Jul 22, 2022 •

edited

Loading

codecov-commenter commented Jul 22, 2022 •

edited

Loading

damiannolan left a comment •

edited

Loading